fix the batch size not respected issue #6528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mengdd: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 00a5dfff128a14d156b9283c |
|
Thanks a lot for the detailed bug report, and fix! I've just added a test that fails on the main branch and works here. |
BoD
approved these changes
May 16, 2025
BoD
reviewed
May 16, 2025
| @@ -90,7 +99,7 @@ class QueryBatchingTest { | |||
|
|
|||
| // Only one request must have been sent | |||
| assertFails { | |||
| mockServer.awaitRequest() | |||
| mockServer.awaitRequest(3.seconds) | |||
There was a problem hiding this comment.
(Not related, but these tests took 30s each time)
martinbonnin
pushed a commit
that referenced
this pull request
Jun 4, 2025
* fix the batch size not respected issue * Add a unit test * Fix node tests hanging --------- Co-authored-by: BoD <BoD@JRAF.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue:
#6527
Fix: If the batch size is reaching limit, send the requests immediately in the current
withLockblock.I have created some dummy fake sample to demonstrate the issue and fix in a simple way: https://gist.github.com/mengdd/d8e51d858e3c0f30018e10ed73686569